Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model View for all organizations involved in an event #982

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rahulharpal1603
Copy link

Fixes #802

Contributor checklist


Description

Created a new component named ModelOrganizationOverview.vue to display the full list of organizations involved in any event. Also, added (+# more) button to truncate the number of organizations displayed to just 1 and all organizations can be seen when clicked on the button.

Also, made the Modal scrollable for screen sizes bigger than 768px. For mobiles, there is no need for scroll. To understand for easily see this video:

2024-10-01.23-39-54.mp4

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 9d87e05
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66fcc1723a49300008b7c2e1
😎 Deploy Preview https://deploy-preview-982--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis self-requested a review October 1, 2024 21:38
@andrewtavis
Copy link
Member

Note that organizationSchema.ts has a weird Prettier bug that we're not fixing for now as the assumption is that it'll go away when we do some updates, @rahulharpal1603 :)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal view for all organizations involved in an event
2 participants