-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#938 Expand fixtures to produce human relatable results #977
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org canceled.
|
Note: Before this is merged, I will add in directions for onboarding new users. Navigate to XYC in order to see organizations, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
num_users = options.get("users") | ||
num_orgs_per_user = options.get("orgs_per_user") | ||
num_groups_per_org = options.get("groups_per_org") | ||
num_events_per_org = options.get("events_per_org") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The errors with the pr_ci_backend
workflow at least, appear to be due to the above 4 possibly being either an int
or None
(despite the defaults that are specified in the parser
arguments on lines L32-L35).
Would doing for instance options["users"]
as opposed to options.get("users")
still work? Or at least specifying the default here as in options.get("users", 10)
so that the .get()
calls don't possibly return None
by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The get method return type is int | None
. Because the method will return None
instead of throwing a KeyError, if the key does not exist. We can just use square bracket notation options["users"]
and the errors are gone 😃.
I still don't know what's up with the frontend error, but is what it is for now. I'm hoping that it goes away when we update the frontend dependencies, which is needed at this point. df04381 Adds in a The last thing I want to do here is play around with the |
Frontend error's still a problem, but I'm going to merge. Tons of changes included in here at this point 😊 New ones are that the events are also being listed, and the work for the backend to do this has also been gotten to. Likely are some minor things that need to get taken care of. Please let me know if you see something! Also feel free to send along a PR with any needed changes :) |
Contributor checklist
Description
Various fixes to the fixtures :)
Related issue