refac(map): Update attribution text to condensed version and change profile on key press [p] #969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
Slowly but surely chipping away at some map stuff..
keydown
event on[x]
causing both the clearing of directions and toggling the route profile. Modified so that the route profile is changed instead onkeydown
events on[p]
. Let me know if there was a reason though for having both actions caused by the same event - wasn't sure© OpenStreetMap
as that is also a fairly common alternative (ref).CyclOSM hosted by OSM France
as opposed toCyclOSM tiles by OSM France
from map: attribution not fully responsive #961 (comment) , given that I'm actually unsure if the CyclOSM styles are officially an OSM France project. However, the tiles themselves are definitely hosted by their infrastructure - so that seemed more appropriate.Also - as I was looking at this, thought about how eventually using localized strings for the map controls/interactions would be a good idea actually - created #968 for it.
Related issue