Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload drf api settings to solve Swagger UI bug #474

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

to-sta
Copy link
Collaborator

@to-sta to-sta commented Oct 18, 2023

Contributor checklist


Description

This PR solves the bug that breaks the Swagger UI endpoint /v1/schema/swagger-ui/. This can be considered a workaround, since we are reloading the drf api_settings after calling the monkeypatch function.

There is currently a open issue on djangorestframework-stubs that is related to this bug. Let's keep the issue #471 open to keep track of the changes.

I have tested the endpoint to make sure it works.

Related issue

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 1aa46e7
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/652f9aaf48513b00085c347a

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 18, 2023
@andrewtavis andrewtavis self-requested a review October 18, 2023 21:41
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @to-sta!

@andrewtavis andrewtavis merged commit 5b6727d into activist-org:main Oct 18, 2023
6 checks passed
@to-sta to-sta deleted the bugSwaggerUI branch April 21, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants