Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint workflow added and contine-on-error added #466

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

to-sta
Copy link
Collaborator

@to-sta to-sta commented Oct 16, 2023

Contributor checklist


Description

In this PR, I added the eslint to the frontend check. I also realized that we have added continue-on-error to the frontend check but not to the backend check. That can be seen in the PR #465, where ruff fails due to import sorting and mypy will not be executed anymore.

I tested ran the command in the frontend docker container.

Related issue

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 5d041aa
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/652d9895a29c620008cf72be

@andrewtavis andrewtavis self-requested a review October 16, 2023 20:03
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 16, 2023
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @to-sta! I was about to send along the formatting changes myself 😊 Those changes came from my autoformat I'm pretty sure. Do I need to setup my code formatter to be ruff?

Appreciate the ESLint workflow as well :) Will close the issue, and let me know if you think there's anything else as far as workflows that we need to look into!

@andrewtavis andrewtavis merged commit 43230e2 into activist-org:main Oct 16, 2023
4 of 5 checks passed
@andrewtavis andrewtavis mentioned this pull request Oct 16, 2023
2 tasks
@to-sta
Copy link
Collaborator Author

to-sta commented Oct 16, 2023

Thank you, @to-sta! I was about to send along the formatting changes myself 😊 Those changes came from my autoformat I'm pretty sure. Do I need to setup my code formatter to be ruff?

If you have the pre-commit hooks installed then you do not need to worry about anything 😉. Will be taking care of before its submitted :). But the VScode extension can also help :).

You can install pre-commit globally with pip install pre-commit or conda if its available there, and install the hooks with pre-commit install. That's it.

@to-sta to-sta deleted the eslintWorkflow branch April 21, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants