-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint workflow added and contine-on-error added #466
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @to-sta! I was about to send along the formatting changes myself 😊 Those changes came from my autoformat I'm pretty sure. Do I need to setup my code formatter to be ruff?
Appreciate the ESLint workflow as well :) Will close the issue, and let me know if you think there's anything else as far as workflows that we need to look into!
If you have the pre-commit hooks installed then you do not need to worry about anything 😉. Will be taking care of before its submitted :). But the VScode extension can also help :). You can install pre-commit globally with pip install pre-commit or conda if its available there, and install the hooks with pre-commit install. That's it. |
Contributor checklist
Description
In this PR, I added the eslint to the frontend check. I also realized that we have added continue-on-error to the frontend check but not to the backend check. That can be seen in the PR #465, where ruff fails due to import sorting and mypy will not be executed anymore.
I tested ran the command in the frontend docker container.
Related issue