Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate #search #975

Merged
merged 1 commit into from
Nov 2, 2018
Merged

deprecate #search #975

merged 1 commit into from
Nov 2, 2018

Conversation

gregmolnar
Copy link
Member

Closes #949

@gregmolnar gregmolnar merged commit e1499b8 into activerecord-hackery:master Nov 2, 2018
@jaredbeck
Copy link
Contributor

This deprecation is a Good Decision. The word "search" is too common. It's hard to .. search for. 😅

y-yagi added a commit to y-yagi/ransack that referenced this pull request Sep 8, 2020
@y-yagi
Remove deprecated #search method
33d8fbe 
`#search` is deprecated in v2.1.1 and it scheduled to remove the
method in v2.3.
activerecord-hackery#975

But the method still exists in v2.3.2. So let's remove the method.

If we removed the method, users can remove the patch for `search`
(`ActiveRecord::Base.class_eval('remove_method :search'`).
@y-yagi y-yagi mentioned this pull request Sep 8, 2020
Merged
y-yagi added a commit to y-yagi/ransack that referenced this pull request Nov 25, 2020
@y-yagi
Remove deprecated #search method
7983167 
`#search` is deprecated in v2.1.1 and it scheduled to remove the
method in v2.3.
activerecord-hackery#975

But the method still exists in v2.3.2. So let's remove the method.

If we removed the method, users can remove the patch for `search`
(`ActiveRecord::Base.class_eval('remove_method :search'`).
viktorsmari added a commit to viktorsmari/openfoodnetwork that referenced this pull request May 8, 2021
@viktorsmari
Ransack.search is deprecated. Use .ransack instead
4aa051a 
activerecord-hackery/ransack#975
viktorsmari added a commit to viktorsmari/openfoodnetwork that referenced this pull request May 8, 2021
@viktorsmari
Ransack.search is deprecated. Use .ransack instead
6a342ae 
activerecord-hackery/ransack#975
@viktorsmari viktorsmari mentioned this pull request May 8, 2021
Merged
y-yagi added a commit to y-yagi/ransack that referenced this pull request Mar 10, 2022
@y-yagi
Remove deprecated #search method
edaf306 
`#search` is deprecated in v2.1.1 and it scheduled to remove the
method in v2.3.
activerecord-hackery#975

But the method still exists in v2.3.2. So let's remove the method.

If we removed the method, users can remove the patch for `search`
(`ActiveRecord::Base.class_eval('remove_method :search'`).
deivid-rodriguez pushed a commit that referenced this pull request Mar 10, 2022
@y-yagi
Remove deprecated #search method (#1147)
0fcf1b5 
`#search` is deprecated in v2.1.1 and it scheduled to remove the
method in v2.3.
#975

But the method still exists in v2.3.2. So let's remove the method.

If we removed the method, users can remove the patch for `search`
(`ActiveRecord::Base.class_eval('remove_method :search'`).
superdev9082 added a commit to superdev9082/ransack that referenced this pull request Feb 16, 2023
@superdev9082
Remove deprecated #search method (#1147)
e9044ea 
`#search` is deprecated in v2.1.1 and it scheduled to remove the
method in v2.3.
activerecord-hackery/ransack#975

But the method still exists in v2.3.2. So let's remove the method.

If we removed the method, users can remove the patch for `search`
(`ActiveRecord::Base.class_eval('remove_method :search'`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmolnar @jaredbeck