Add support for sorting by scopes #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For when we want to sort by something complex such as the result of a SQL function.
benlangfeld
force-pushed
the
sort-by-scopes
branch
from
d4f66e5
to
bdd1c24
Compare
|
Please let me know what I can do to help this get into a 2.1.0 release as quickly as possible. |
|
Awesome, thanks for merging @seanfcarroll ! Any idea when 2.1.0 might be released? Is there anything I can do to help with that? |
|
That's been released now, cheers @benlangfeld |
|
Excellent! Thank you very much @seanfcarroll |
|
Hi, is there any chance this one can be support on 1.8 branch? As our system still on Rails 4. :( |
|
We have ported this to 1.8 branch since we're still on Rails 4 also (I hope not for long time). Is there any interest from core team to submit this port as a pull request? |
|
@simi It would be great. We have a branch for 1.8, just open the PR against that. Thank you! |
|
@gregmolnar PR submitted. ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For when we want to sort by something complex such as the result of a SQL function.
Credit: This solution was borrowed from this gist.