add support for rails 5.2 #859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbonislawski is there any progress with this? do you need some help? |
|
@gssbzn I'm working on polyamorous at the moment, since it still fails for me still despite "update" and green specs on polyamorous. I'm considering adding PR for merging polyamorous into ransack, since metasearch and squeel are dead for 3-6 years and having polyamorous doesn't make sense at the moment. |
|
Hi @bbonislawski - wondering if the merge with upgraded Polyamorous gem 3 days ago has fixed your issues. I opened a merge and PR review on your repo so we can use your Rails 5.2 fixes. Let me know if I can be of any assistance! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.