Config option for turning off custom scope argument sanitization #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a lot of discussion about ways to get around Ransack converting scope values to booleans. Here are just a few places: #509, #593, #580, #566. This PR specifically addresses the tests presented in #575.
An easy solution to this would be to simply stop making these conversions. But then we run the risk of breaking backwards compatibility. So instead of changing them, I've added a config option to turn them off.
It'd be easy to modify this to make the config option more granular. We could set it up for the user to specify what exact truthy/falsey values they would like converted, and use the default settings if this config is NOT specified. For example, instead of:
we could do this:
But I don't know if that level of detail is needed/desired. If being able to disable boolean conversion is not enough, this could be added later on.