-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead MongoDB code #1345
Remove dead MongoDB code #1345
Conversation
@deivid-rodriguez could you review this change please. |
Is this used by https://github.com/activerecord-hackery/ransack-mongoid? If no, then this is good to go as is without any concerns. If yes, then this seems also fine anyways given that you already archived the ransack-mongoid repo back in march, but we consider backwards compatibility, right? |
@deivid-rodriguez yes this is correct, the repo is archived. There was little interest for this feature, and if this is something that might be wanted in future it would probably make sense to write it from the ground-up for Mongo, IMHO. |
Ok, you know best the history of this. I think to be strict with backwards compatibility we should ship this with a major version, but other than that looks fine. |
That's an excellent point @deivid-rodriguez ! Should we hold this (and #1348) until the next version bump, and make it 4.0.0? Are we currently on a 2 week cycle for version bumps? |
We were but I lost the rhythm a couple of cycles ago... 😅. We can recover it on Thursday and get 4.0.0 out if it seems fine to you? |
Works for me!! 🎸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright let's do it!
Closes #1344