Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ruby 2.6 support #1311

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Drop Ruby 2.6 support #1311

merged 1 commit into from
Apr 12, 2022

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Apr 12, 2022

@yahonda
Copy link
Contributor Author

yahonda commented Apr 12, 2022

Background for this change #1310 (comment)

deivid-rodriguez
deivid-rodriguez requested changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to bump the required_ruby_version in the gemspec file.

@yahonda
Copy link
Contributor Author

yahonda commented Apr 12, 2022

Updated required_ruby_version.

deivid-rodriguez
deivid-rodriguez approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!!

@deivid-rodriguez deivid-rodriguez merged commit 08b2447 into activerecord-hackery:main Apr 12, 2022
@yahonda yahonda deleted the drop_ruby26 branch April 12, 2022 12:25
@scarroll32
Copy link
Member

scarroll32 commented Apr 12, 2022 •
edited
Loading

@yahonda thank you for these PRs.

Will this solve the failing cronjob issue?

What is the cronjob for anyway?

@yahonda
Copy link
Contributor Author

yahonda commented Apr 12, 2022

The cronjob is created to run CI against Rails main branch daily to see if some changes at Rails affect Ransack or not. Refer to #1192 for the background.

#1309 should address the cronjob failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yahonda @scarroll32 @deivid-rodriguez