Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sort using alias #1223

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Enable sort using alias #1223

merged 3 commits into from
Jul 6, 2021

Conversation

waldyr
Copy link
Contributor

@waldyr waldyr commented May 6, 2021

Duplicates #766 and #1084 but this one have tests. All credit should be given to the PR authors.

@scarroll32
Copy link
Member

This looks great @waldyr, any chance to add a note to the documentation?

@waldyr
Copy link
Contributor Author

waldyr commented Jun 10, 2021

Sure. I just don't know what to add 😆

The example here is a a_or_b so it won't really work with sorting. Should I add another alias on the example and explain that you can use with sort_link or maybe you have something else in mind.

@scarroll32
Copy link
Member

Should I add another alias on the example and explain that you can use with sort_link

@waldyr this would cover it, thank you.

@waldyr
Copy link
Contributor Author

waldyr commented Jul 5, 2021

@seanfcarroll done. Let me know if it's enough

@scarroll32
Copy link
Member

@waldyr that is great, thank you. I'll merge it once the CI has completed.

@scarroll32 scarroll32 merged commit 16ce911 into activerecord-hackery:master Jul 6, 2021
This was referenced Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants