Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RuboCop and configure GitHub Actions to run RuboCop #1185

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Enable RuboCop and configure GitHub Actions to run RuboCop #1185

merged 3 commits into from
Dec 23, 2020

Commits on Dec 23, 2020

  1. Enable RuboCop 

    - RuboCop version is locked to 0.81.0 which supports Ruby 2.3
Once Ransack bumps the required_ruby_version, RuboCop can be bumped.

- `DisabledByDefault: true` not to apply all of default cops

- Some Layout and Style cops are enabled to make initial changes small
Other cops can be enabled later.
    @yahonda
    yahonda committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    b74842a View commit details
    Browse the repository at this point in the history

  2. Apply RuboCop auto correct ry running bundle exec rubocop -a

    @yahonda
    yahonda committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    7eba779 View commit details
    Browse the repository at this point in the history

  3. Run RuboCop using GitHub Actions

    @yahonda
    yahonda committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    e083efd View commit details
    Browse the repository at this point in the history