Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes polymorphic joins. #1122

Merged
merged 1 commit into from
May 27, 2020
Merged

Fixes polymorphic joins. #1122

merged 1 commit into from
May 27, 2020
+19 −6

Commits on May 11, 2020

  1. Fixes polymorphic joins. 

    * Polymorphic joins have been missing a critical join constraint that
is responsible for only returning polymorphic records of the specified
type.

* Override ActiveRecord::Reflection::AbstractReflection#join_scope to
add this constraint if the reflection is polymorphic.
    @PhilCoggins
    PhilCoggins committed May 11, 2020
    Configuration menu
    Copy the full SHA
    01d35ef View commit details
    Browse the repository at this point in the history