Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/Fix for subquery in Rails 5.2.4 #1112

Merged
merged 5 commits into from
Mar 24, 2020
Merged

Test/Fix for subquery in Rails 5.2.4 #1112

merged 5 commits into from
Mar 24, 2020

Conversation

stevenjonescgm
Copy link
Contributor

@stevenjonescgm stevenjonescgm commented Mar 23, 2020 •
edited
Loading

re #1111

  • Fixed CONTRIBUTING doc
  • Added failing spec
    • RAILS=v5.2.3 bundle exec rspec spec/ransack/adapters/active_record/context_spec.rb:83 passes
    • RAILS=v5.2.4 bundle exec rspec spec/ransack/adapters/active_record/context_spec.rb:83 fails (likewise untagged v5.2.4.2/5-2-stable)
    • RAILS=v6.0.2.1 bundle exec rspec spec/ransack/adapters/active_record/context_spec.rb:83 passes
  • proposed fix (assuming CI runs on initial commits to show history of failure before success
  • additional bug spec for not_eq additional conditions, pending because I don't know how to fix that one

@scarroll32
Copy link
Member

@stevenjonescgm this looks great, thanks for your contribution.

@scarroll32 scarroll32 merged commit 55a83f0 into activerecord-hackery:master Mar 24, 2020
@stevenjonescgm stevenjonescgm deleted the rails-5.2.4 branch March 24, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjonescgm @scarroll32