Drop old rubies support #1070
Merged
Drop old rubies support #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
drop_old_rubies_support
branch
from
947c8d4
to
c186772
Compare
|
Also, note that although installation was permitted on old rubies, README currently notes that the gem only works on ruby 2.2 or higher. So this PR might only be effectively dropping support for ruby 2.2. |
deivid-rodriguez
force-pushed
the
drop_old_rubies_support
branch
from
c186772
to
5740840
Compare
|
Ping! Improved and rebased. |
We no longer support Rails 3.x
Nowadays, these compatibility issues are handled by bundler automatically. In any case, I updated the note to be more up to date.
deivid-rodriguez
force-pushed
the
drop_old_rubies_support
branch
from
5740840
to
1cd4d64
Compare
|
Rebased this one and all of my other PRs now that CI is green 👍. |
|
Hi there! Any news? |
tom-lord
referenced
this pull request
Jun 10, 2021
README already mentions that `Ransack is supported for Rails 6.1, 6.0, 5.2 on Ruby 2.6.6 and later.` d508857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to create a PR to fix some issues with (unreleased) ruby 2.7, but I want to use String#+@, which is only available since ruby 2.3.
I can create a different patch (backwards compatible with all currently supported rubies) using
String#dup, but since ruby 1.9, 2.0, 2.1 and 2.2 reached their end of life a while ago, I figure we could drop support for those.