Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Rails 6 #1027

Merged
merged 8 commits into from
Jun 11, 2019

Conversation

vrodokanakis
Copy link
Contributor

@vrodokanakis vrodokanakis commented May 28, 2019

Closes #1021

Rails 6 is still under development and breaking changes are happening even in RC versions. Just a month a go this pull request rails/rails#36120 was merged after 6.0.0.rc1 was released.

This branch is compatible with latest 6-0-stable branch , which means it will probably be compatible with Rails 6.0.0.rc2 when its released if no future changes are made.

CI will pass if #1024 is merged.

@jscheid
Copy link

jscheid commented May 31, 2019

I'm getting the following, any ideas?

Sorry read the part about latest stable 6-0-stable branch too late..

@vrodokanakis
Copy link
Contributor Author

vrodokanakis commented May 31, 2019

To help anyone else that wants to try this branch you need

  1. 6-0-stable Rails branch and
  2. cherry-pick the commit from Fix failing specs on local machine [fix #1023] #1024 pull request

We are using the above in production successfully.

@vrodokanakis vrodokanakis force-pushed the support_rails_6 branch 2 times, most recently from 6e88123 to 9f1ba1b Compare June 11, 2019 10:02
@vrodokanakis
Copy link
Contributor Author

@seanfcarroll Ι rebased my branch with latest master and also did a fix for sqlite3 due to different dependencies in Rails 6 (sqlite 1.4 is needed, instead of 1.3) for CI to pass.

@scarroll32
Copy link
Member

Thanks a lot @vrodokanakis !

@scarroll32 scarroll32 merged commit 2aed3ea into activerecord-hackery:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails 6 Support
3 participants