performance issue with SQL Adapter

[sschwing3]

I had a performance problem when i used ransack (1.6.6) with rails 4.2 and activerecord-sqlserver-adapter (4.2.5 b917f4b)

When i put executed this query in rails console
Todo.joins(:user).ransack({"user_id_eq"=>"11"}).result

the sql server got the following queries

EXEC sp_executesql N'SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_TYPE = ''BASE TABLE'' ORDER BY TABLE_NAME' go
EXEC sp_executesql N'SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_TYPE = ''BASE TABLE'' ORDER BY TABLE_NAME' go
EXEC sp_executesql N'SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_TYPE = ''BASE TABLE'' ORDER BY TABLE_NAME' go
EXEC sp_executesql N'SELECT [todos].* FROM [todos] INNER JOIN [users] ON [users].[id] = [todos].[user_id] WHERE [todos].[user_id] = 11' go

In the config, I enabled schema cache dump (config.active_record.use_schema_cache_dump = true) but nothing happend.

I took a look on the code and found the line, which is responsible for the table name look up:

lib/ransack/adapters/active_record/context.rb: at line 28:
28: unless connection.table_exists?(table)
I changed it to connection.schema_cache.table_exists?(table) and the table name look up stopped.

My Question: Is this performance fix correct or do i get some problems with it?

[jonatack]

Thank you @sschwing3 for this report. You may have found a regression caused by this commit.

Would you like to make a pull request for a fix, with a test spec and update to the changelog?

[zhangsoledad]

it's terrible, one query , execute so many time `table_exists`

[jonatack]

@zhangsoledad I have never used SQL Server. You are free to make a pull request to fix it 😸

[sschwing3]

hi guys,

my code at the top fixed the problem for me, but i don't know how to write a test spec, that's why I didn't pulled my solution.

@zhangsoledadhttps://github.com/zhangsoledad

Am 11.09.2015 um 11:36 schrieb Jon Atack <[email protected]mailto:[email protected]>:

@zhangsoledadhttps://github.com/zhangsoledad I have never used SQL Server. Feel free to make a pull request to fix it instead of complaining [:smile_cat:]

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/553#issuecomment-139500322.

[jonatack]

Hi @sschwing3 I think it's safe to use your fix because it reverts back to the original implementation. Please let me know if you'd like to make a PR.