1.6.x: can't add a new key into hash during iteration

[nateberkopec]

I think 1.6.0 broke multiparameter attributes like dates. Given a form like:

 <%= f.date_select :start_time_gteq %>

...where start_time is a DateTime, it looks like collapse_multiparameter_attributes tries to modify a hash in an iteration. I believe this was introduced by ee571fe.

Here's the relevant stacktrace lines:

active_support/hash_with_indifferent_access.rb:97:in `[]='
    regular_writer(convert_key(key), convert_value(value, for: :assignment))
  active_support/hash_with_indifferent_access.rb:97:in `[]='
    regular_writer(convert_key(key), convert_value(value, for: :assignment))
  ransack/search.rb:167:in `block in collapse_multiparameter_attributes!'
    attrs[real_attribute] ||= []
  ransack/search.rb:156:in `each_key'
    attrs.each_key do |k|
  ransack/search.rb:156:in `collapse_multiparameter_attributes!'
    attrs.each_key do |k|
  ransack/search.rb:47:in `build'
    collapse_multiparameter_attributes!(params).each do |key, value|
  ransack/search.rb:39:in `initialize'
    build(params.with_indifferent_access)

[jonatack]

Thank you! You are correct. Reverted.

[jonatack]

Test added and change log updated. Thanks again @nateberkopec 😃

[nateberkopec]

👍 !