Cybersource: Update order of XML fields #5302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update order of XML fields for add_auth_service with this new order aggregatorID, reconciliationID, firstRecurringPayment and mobileRemotePaymentType can now be passed for NetworkTokenizationCreditCard.
Buitragox
reviewed
Oct 10, 2024
| when :apple_pay, :google_pay | ||
| xml.tag! 'paymentSolution', @@wallet_payment_solution[payment_method.source] | ||
| end | ||
| payment_solution = payment_method.try(:network_token?) ? NT_PAYMENT_SOLUTION[payment_method.brand] : @@wallet_payment_solution[payment_method.source] |
There was a problem hiding this comment.
Minor detail. I think we could skip the .try here, since the early return guarantees that it is a NetworkTokenizationCreditCard. Same thing in the add_payment_network_token method.
There was a problem hiding this comment.
NetworkTokenizationCreditCard can be Network Token, ApplePay or GooglePay and payment_method.try(:network_token?) ensures that it is a Network Token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update order of XML fields for add_auth_service with this new order aggregatorID, reconciliationID, firstRecurringPayment and mobileRemotePaymentType can now be passed for NetworkTokenizationCreditCard.