Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorize.net: certificates added for digicert #5298

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Authorize.net: certificates added for digicert #5298

wants to merge 3 commits into from
+33 −0

Conversation

dawoodmalhi
Copy link

Added new certificates since authorize.net is migrating from Entrust to DigiCert.

Reference Article: https://support.authorize.net/knowledgebase/Knowledgearticle/?code=KA-05545
Certificates Source: https://support.authorize.net/knowledgebase/Knowledgearticle/?code=000003009

@dawoodmalhi dawoodmalhi mentioned this pull request Oct 9, 2024
Open
@dawoodmalhi dawoodmalhi marked this pull request as draft October 10, 2024 06:59
@dawoodmalhi dawoodmalhi marked this pull request as ready for review October 10, 2024 06:59
@dawoodmalhi
Copy link
Author

@yunnydang can you please review these changes?

bradbroge
bradbroge requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@bradbroge bradbroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 cert already exists in the file, and I'm unclear where the other came from. I'm inclined to deny this change.

lib/certs/cacert.pem Outdated Show resolved Hide resolved
lib/certs/cacert.pem Outdated Show resolved Hide resolved
bradbroge
bradbroge reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@bradbroge bradbroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will plan to merge this either late this week, or early next week. I see that there is a deadline of 23/24th October, we will merge before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ligator Ligator Ligator left review comments

@bradbroge bradbroge bradbroge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawoodmalhi @Ligator @bradbroge