Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authorize/capture and customer update to Pin Payments gateway #1268

Conversation

keithpitt
Copy link
Contributor

Added the following new methods to the Pin Payments gateway:

  • #authorize(money, creditcard, options)
  • #capture(money, token, options)
  • #update(customer_token, credit_card, address: { ... })
  • #update_customer(customer_token, email: "[email protected]")

@ntalbott
Copy link
Contributor

Hey @keithpitt, great to see Pin getting auth/capture!

On the update methods:

  • update_customer is out of scope for ActiveMerchant - please remove.
  • update needs to match the signature used by other gateways (update(token, credit_card, options)), and I'm not clear if the current signature you have does; the key thing is that the token returned by store should be the token passed to update - is that the case here?

Can't wait to get this reviewed and merged - thanks!

@ntalbott
Copy link
Contributor

@keithpitt update_customer is out of scope for ActiveMerchant - can you pull it out? Otherwise this looks good.

@keithpitt
Copy link
Contributor Author

Hey @ntalbott, sorry for the late reply. I've removed the update_customer method.

You do pass the card token to update, see: https://github.com/Shopify/active_merchant/pull/1268/files#diff-fd69b950fb50e7849fecfb121ce5ab1bR103

Thanks again for poking me about this :)

ntalbott pushed a commit that referenced this pull request Jul 3, 2014
@ntalbott ntalbott closed this in 5363a92 Jul 3, 2014
@keithpitt
Copy link
Contributor Author

Thanks for taking the time to do this for me :) ❤️

andys pushed a commit to maxio-com/active_merchant that referenced this pull request Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants