This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
[MOBFND-40] Update version to 3.9.0 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding “name” field to payload;updated nimble to version 7.3.4
* Add iOS Backgrounded Event. * Bump Xcode CI version * Bump pods * Updated properties * Simplified App Backgrounded call * Fixed test since we dropped the param. * Reverted xcode CI version number
…io#836) * Prepare for release 3.7.0 * Updated cartfile. * Updated version in SEGAnalytics.m * Updated version in readme instructions.
* Preparing 3.8.0-beta.0 release.
… done so that tvOS targets could build without linker errors. (segmentio#842)
* Support SSL pinning Client integrations can optionally pass in a NSURLSessionDelegate in the SEGAnalyticsConfiguration object. If set, NSURLSessionDelegate callbacks are forwarded to the client code where SSL pinning checks can be implemented * test httpSessionDelegate configuration
* Fix for LIB-1416 & Github segmentio#846 - Stops blindly passing dictionaries. - Property dictionaries are checked for NSCoding conformance to ensure they can be serialized. - Property dictionaries are deep copied so contents can’t change while the pipeline is in progress. - Puts a try/catch arrangement as a temporary guard against crashes for serialization failures until the storage format can be changed. * Fixed missing ; * Added test for deepCopy/conformance additions.
…mentio#856) * Respond to changes regarding advertising ID. * Removed unnecessary context. * Remove extraneous NSNull handling causing tests to fail. * Added weakify/strongify macros. * Removed extraneous NSNull checking. * Put locking around static context access.
…#861) * Stops using UserDefaults for queue on tvOS and uses NSCachesDirectory Changes storage to fileStorage and userDefaultsStorage. Utilizes userDefaults on tvOS for information such as anonymousID and configuration, but moves tvOS's queue into the NSCachesDirectory. The reasoning is that tvOS has a 1mb limit for UserDefaults and the queue can grow rapidly in size, leading to app crashes when saving more than 1mb of data to UserDefaults. * Adds a constant for key. Seperate cache dir and appSupport dir functions. Removes unused init. * Adds functionality to remove old UserDefaults queue on tvOS. Updates migrated removal block to account for tvOS now that the queue is no longer in UserDefaults. Adds back in a #else and #endif that was accidently removed. * Adds tvOS unit test target * Adds new AnalyticsTestsTVOS scheme * Updates pods to include all test pods for AnalyticsTestsTVOS * Fixes unit test import for QuickTVOS * Add tvOS options for make file * Enabled code coverage on tvOS tests * Fix up unit test warning "result of expect is never nil" * Adds test to ensure that UserDefaults SEGQueue is cleared on initialization for tvOS & iOS * Adds test to ensure SEGQueue is empty when missing form file storage * Reverts unnecessary import for QuickTVOS * Adds test for FileStorage caches directory helper * Fix up: Adds SwiftTryCatch pod to tvOS test target * Fix up makefile to have correct build target for build-ios & build-tvos * Fix up: updates xcodebuild destination to match devices found on circleci * Break up ios and tvos build/test steps * Circleci: Cache pods * Fix up: tvOS test build * Fix up spacing * Fix up flaky unit test Co-authored-by: Connor Ricks <[email protected]>
* Fixing a crash from plist->json conversion where result is not actually a dictionary. * Made code flow the same as non-conversion. * Set compatibility to 10.0. * Fixed issues around setting nil values even though they are expected.
…ation enablement (segmentio#863) * Address Issue segmentio#851; Expect dictionary as well for for integration enablement. * Fixed broken test.
segmentio#864) * Disabled tvOS tests temporarily. * Updated podfile lock. * Fixed LIB-1698; Differences observed in how ios/android pass userId/anonId in traits. * Another podfile lock update. * Fixed test. * Set swift version for tests. * Reverted podfile lock changes due to incompatibilities.
* LIB-1656: Added nanosecond timestamps * Actually use the timestamp we’re carrying around. * In case the context is modified, preserve the timestamp. * Bump timestamp nanosecond precision to 9. * Only carry over the timestamp during a modify if there was one to begin with. * Added experimental options to configuration. * Added a second version of 8601 date creation. * Respect experimental value now present in config. * Added nanosecond time test. Co-authored-by: Brandon Sneed <[email protected]>
* Implement maximum request size * Add test when batch exceeds the size * Execute check before gzip * Remove stub request
* Add name and properties to auto screen reporting * Make seg_topViewController handle tab and custom container VCs * Simplify SEGScreenReporting protocol Inspired by comments from @f2prateek, simplify the the `SEGScreenReporting` protocol to replace the name and properties fields with a single method (`seg_trackScreen`) that can be implemented when screen tracking for a specific view controller that needs a custom name, properties, or options. * Update Nimble to build with Xcode 10.2 * Add tests for seg_topViewController * fixed a crash in file storage when trying to get a string stored using old SDK version (segmentio#880) * Fixed issue where build/version were removed from Application Opened events from background state. * Publish filenames used for data storage (segmentio#865) * Remove tvos test from scheme setup. * Fixed selector reference. * Removed unused code. Co-authored-by: David Whetstone <[email protected]> Co-authored-by: Sergei Guselnikov <[email protected]> Co-authored-by: Brandon Sneed <[email protected]> Co-authored-by: Błażej Biesiada <[email protected]>
…Backported from segmentio#888 (segmentio#897) Co-authored-by: Brandon Sneed <[email protected]>
| - run: make test-pretty | ||
| - run: make build-ios | ||
| - run: make test-ios | ||
| - run: make build-tvos |
There was a problem hiding this comment.
This is part of Segment's CircleCI configuration, we don't run the CI build on this repo but I can remove it if we do in the future
alinak-earnin
approved these changes
Jun 9, 2020
sivan-earnin
approved these changes
Jun 10, 2020
|
A bit strange it has |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link
https://earnin.atlassian.net/browse/MOBFND-40
Implementation Details
Checklist
3rd party SDK PRs: