Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuboCop Packaging #936

Merged

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Sep 8, 2024

For parity with activeadmin

Ref: activeadmin/activeadmin#6462

@tagliala tagliala force-pushed the chore/introduce-rubocop-packaging branch from 3c9408b to c93cd1c Compare September 8, 2024 07:28
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (4b4ec73) to head (657f319).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          14       14           
  Lines         557      557           
=======================================
  Hits          551      551           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

For parity with activeadmin and arbre

Refs:
- activeadmin/activeadmin#6462
- activeadmin/arbre#212
@tagliala tagliala force-pushed the chore/introduce-rubocop-packaging branch from c93cd1c to 657f319 Compare September 8, 2024 07:31
@javierjulio javierjulio self-requested a review September 8, 2024 15:59
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit aa07a79 into activeadmin:master Sep 8, 2024
21 checks passed
@tagliala tagliala deleted the chore/introduce-rubocop-packaging branch September 8, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants