Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant encoding #614

Merged

Conversation

tagliala
Copy link
Contributor

This magic comment is not needed anymore because the default encoding of source code files assumed by Ruby 2 is utf-8, and the minimum required Ruby version is 2.7

Autofixed with:

rubocop -a

This magic comment is not needed anymore because the default encoding of
source code files assumed by Ruby 2 is utf-8, and the minimum required
Ruby version is 2.7

Autofixed with:
```
rubocop -a
```
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (b6dac5d) to head (52ab11f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          17       17           
  Lines         458      458           
=======================================
  Hits          432      432           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio self-requested a review August 26, 2024 19:32
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 2594450 into activeadmin:master Aug 26, 2024
21 checks passed
@tagliala tagliala deleted the chore/remove-redundant-encoding branch August 26, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants