Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.2 changelog / release notes #276

Merged
merged 3 commits into from
Apr 16, 2023
Merged

V3.2 changelog / release notes #276

merged 3 commits into from
Apr 16, 2023

Conversation

kbrock
Copy link
Collaborator

@kbrock kbrock commented Apr 14, 2023

Release notes for v3.2.0

- add changelog, issues, and other metadata link to rubygems
- add diff references to changelog
added @ to names
added version information
added a few backticks and escaped some ruby (was far too much to fix all)
added some issue numbers (low hanging fruit only)
Copy link
Collaborator Author

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically this is just done from the command line and pushed directly into the branch.
so self reviewing / merging.

Thanks all for the hard work.

HMM... not allowed to do that anymore

@kbrock
Copy link
Collaborator Author

kbrock commented Apr 14, 2023

@adampal @flavorjones I can't merge this. Needs a review from another maintainer.
Can one of you +1 this and then I'll release?

In the future I will skip the PR and see if I can push directly to master. (Prefer not to do that but...)

I did try this from the command line but...

[master] active_hash $ git push upstream master
remote: Resolving deltas: 100% (8/8), completed with 4 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: At least 1 approving review is required by reviewers with write access.
To https://github.com/zilkey/active_hash.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/zilkey/active_hash.git'

heh. Maybe it is my old 'upstreamreference, but I think the protections aroundgit` may make this difficult.


After you are here, could you +1 #254 ? We dropped travis a while ago and that broke local rake (default: rspec).

Again, I'm not allowed to fix that since I put in the PR.

@kbrock kbrock merged commit 7a07bcc into active-hash:master Apr 16, 2023
@kbrock kbrock deleted the v3.2 branch April 16, 2023 04:14
@rgarver
Copy link
Collaborator

rgarver commented May 5, 2023

Is this still waiting to go up to Rubygems or is there more to be done? This release seems long overdue, I'm excited to switch to an official version rather than from source.

@kbrock
Copy link
Collaborator Author

kbrock commented May 6, 2023

@rgarver Ryan, thanks for the polite ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants