Fix deprecation warnings #259
Conversation
``` DEPRECATION WARNING: Rails 7.0 has deprecated Enumerable.sum in favor of Ruby's native implementation available since 2.4. Sum of non-numeric elements requires an initial argument. ```
``` DEPRECATION WARNING: Time#to_s(:number) is deprecated. Please use Time#to_fs(:number) instead. ```
yujideveloper
force-pushed
the
fix/deprecation-warnings
branch
from
17fd89f
to
00f9811
Compare
| @@ -13,7 +13,7 @@ def data_from_multiple_files | |||
| loaded_files = full_paths.collect { |path| load_path(path) } | |||
|
|
|||
| if loaded_files.all?{ |file_data| file_data.is_a?(Array) } | |||
| loaded_files.sum | |||
There was a problem hiding this comment.
is this something we can fix in the definition of sum?
Or is this just a place where the method signature has been messed up in upstream rails?
There was a problem hiding this comment.
your comments explain that enough.
ignore.
(but still want to say darn)
|
@yujideveloper do you know what the business process is around the review/merge? Am I allowed to review and merge your changes? |
|
Sorry, late reply.
I don't know it in this project.
I think it's better to have two different reviewers. But as you say, I think nothing will be merged in this project now. |
I fixed two deprecation warnings below.
DEPRECATION WARNING: Rails 7.0 has deprecated Enumerable.sum in favor of Ruby's native implementation available since 2.4. Sum of non-numeric elements requires an initial argument.DEPRECATION WARNING: Time#to_s(:number) is deprecated. Please use Time#to_fs(:number) instead.