Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rspec config when SKIP_ACTIVE_RECORD enabled #258

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Fix rspec config when SKIP_ACTIVE_RECORD enabled #258

merged 1 commit into from
Aug 25, 2022

Conversation

yujideveloper
Copy link
Contributor

@yujideveloper yujideveloper commented Aug 16, 2022 •
edited
Loading

Overview

I fixed rspec config when SKIP_ACTIVE_RECORD enabled.
It broke at #256.

Reproduce command

SKIP_ACTIVE_RECORD=1 bundle exec rspec

Expected behavior

All examples are passed.

Actual behavior

All examples are failed.

@kbrock kbrock self-assigned this Aug 22, 2022
kbrock
kbrock approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@kbrock kbrock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

Could you update the description to explain why this fixes?
The tests looked green before and after this change

@yujideveloper
Copy link
Contributor Author

I updated PR's description.
And I rebased my branch.

@kbrock kbrock merged commit cbf3d20 into active-hash:master Aug 25, 2022
@yujideveloper yujideveloper deleted the fix/test-skip-activerecord branch August 26, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrock kbrock kbrock approved these changes

Assignees

@kbrock kbrock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yujideveloper @kbrock