refactor: use public_send instead of zip and to_proc in pluck

active-hash · Feb 10, 2024 · 33f0960 · 33f0960
1 parent 9341e7a
commit 33f0960
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/active_hash/relation.rb b/lib/active_hash/relation.rb
@@ -144,10 +144,10 @@ def size
 
     def pluck(*column_names)
       if column_names.length == 1
-        all.map(&column_names.first.to_sym)
+        column_name = column_names.first
+        all.map { |record| record.public_send(column_name)  }
       else
-        # `tap with break` can be replaced with yield_self in Ruby 2.5 or then in Ruby 2.6
-        column_names.map { |column_name| all.map(&column_name.to_sym) }.tap { |values| break :zip.to_proc.(*values) }
+        all.map { |record| column_names.map { |column_name| record.public_send(column_name) } }
       end
     end