Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](SQL Panel): optimize remark column display #339

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

siriuswh0327
Copy link
Contributor

@siriuswh0327 siriuswh0327 commented Nov 22, 2023

No description provided.

@siriuswh0327 siriuswh0327 requested a review from LZS911 November 22, 2023 06:02
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
88.83% (-0.02% 🔻)
7134/8031
🟡 Branches 68.12% 2444/3588
🟢 Functions
87.54% (-0.03% 🔻)
2270/2593
🟢 Lines
88.92% (-0.02% 🔻)
7022/7897

Test suite run success

943 tests passing in 278 suites.

Report generated by 🧪jest coverage report action from eb274d5

@siriuswh0327 siriuswh0327 requested review from anny1021 and LZS911 and removed request for LZS911 and anny1021 November 23, 2023 05:36
@@ -177,9 +189,10 @@ export const SQLPanelColumns: (params: {
{
dataIndex: 'remark',
title: () => t('sqlManagement.table.comment'),
width: 200,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接给固定width 吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看着其他地方带EditText组件的是给固定就写了固定宽,产品那边验收没有异议。

@LZS911 LZS911 merged commit 315e815 into main Nov 24, 2023
2 checks passed
@LZS911 LZS911 deleted the fix/DMS-650 branch November 24, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants