Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core debug #98

Merged
merged 4 commits into from
Sep 5, 2019
Merged

Core debug #98

merged 4 commits into from
Sep 5, 2019

Conversation

jclem
Copy link
Contributor

@jclem jclem commented Aug 29, 2019

This pull request adds helpers for group and endgroup.

  • Adds core.startGroup('name') and core.endGroup() for simple commands
  • Adds core.group('name', asyncFn) for wrapping asynchronous commands

damccorm
damccorm approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't know we expose this 😃

@eine eine mentioned this pull request Sep 5, 2019
Closed
@jclem jclem merged commit eb4c328 into master Sep 5, 2019
@jclem jclem deleted the core-debug branch September 5, 2019 13:47
@xt0rted xt0rted mentioned this pull request Sep 5, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damccorm damccorm damccorm approved these changes

@bryanmacfarlane bryanmacfarlane Awaiting requested review from bryanmacfarlane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jclem @damccorm