[Artifacts] More detailed information for chunked uploads #957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating some 503s that can occur during artifact upload, the server reports that certain chunks were missing as part of the upload. The client thinks that all chunks were uploaded so it's unclear where something could be going wrong. This PR changes a few things
largeFileStatus
that was used to display information about large files every 1 second. Within a 1 second period there can be more than 1 chunk uploaded for a file so I've gotten rid of that and every single HTTP call simply gets outputted. The downside of this is that there are more logs which makes things a bit more verbose but people generally don't care about that and it's much better to display all this information for diagnostic purposesOld output: https://github.com/konradpabjan/artifact-test/runs/4434790411?check_suite_focus=true
New output: https://github.com/konradpabjan/artifact-test/runs/4435915324?check_suite_focus=true
The new output is a bit more verbose, perhaps a bit too much but I this will help a lot in helping to diagnose weird issues where the client thinks it's uploaded everything but the server reports certain chunks are missing