Updates to logging for artifact uploads #949
Conversation
| await uploadHttpClient.patchArtifactSize(uploadResult.totalSize, name) | ||
|
|
||
| if (uploadResult.failedItems.length > 0) { | ||
| core.info( |
There was a problem hiding this comment.
Could this be a warning or is this scenario expected to happen?
There was a problem hiding this comment.
So there is a continueOnError option that we have available: https://github.com/actions/toolkit/tree/main/packages/artifact#available-options
It's not really used and we default to false for that so this is mainly for action authors that are doing some weird stuff. If that is true then it would error out earlier. The existing library also returns an array of failedItems: https://github.com/actions/toolkit/tree/main/packages/artifact#upload-result so it's basically up to authors to do whatever they want with that failed upload result list.
I lean on not creating a warning because it shows up as an annotation and in the past there was pushback about warning annotations we made if there were no files found with the input path
Co-authored-by: campersau <[email protected]>
* More details logs during artifact upload * extra logging * Updates to artifact logging + clarifications around upload size * Fix linting errors * Update packages/artifact/src/internal/artifact-client.ts Co-authored-by: campersau <[email protected]> Co-authored-by: campersau <[email protected]>
This fixes a bunch of small things that make the upload process better
Improved logs (with step debugs enabled): https://github.com/konradpabjan/artifact-test/runs/4359261863?check_suite_focus=true
Older logs for comparison: https://github.com/konradpabjan/artifact-test/runs/4266680264?check_suite_focus=true
Closes:
actions/upload-artifact#208
More clear error message to close out:
actions/upload-artifact#243