Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate audit workflow #450

Merged
merged 1 commit into from
May 7, 2020

Conversation

ericsciple
Copy link
Contributor

@ericsciple ericsciple commented May 7, 2020

Create a separate badge for audit

@@ -4,7 +4,8 @@
</p>

<p align="center">
<a href="https://github.com/actions/toolkit"><img alt="GitHub Actions status" src="https://github.com/actions/toolkit/workflows/toolkit-unit-tests/badge.svg"></a>
<a href="https://github.com/actions/toolkit/actions?query=workflow%3Atoolkit-unit-tests"><img alt="Toolkit unit tests status" src="https://github.com/actions/toolkit/workflows/toolkit-unit-tests/badge.svg"></a>
Copy link
Contributor Author

@ericsciple ericsciple May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is hard to see

  1. I appended /toolkit_/actions?query=workflow%3Atoolkit-unit-tests to the existing link. Previously the badge linked to the repo (already on that page when reading the README). Better to link to the workflow.

  2. I updated the alt description

@@ -4,7 +4,8 @@
</p>

<p align="center">
<a href="https://github.com/actions/toolkit"><img alt="GitHub Actions status" src="https://github.com/actions/toolkit/workflows/toolkit-unit-tests/badge.svg"></a>
<a href="https://github.com/actions/toolkit/actions?query=workflow%3Atoolkit-unit-tests"><img alt="Toolkit unit tests status" src="https://github.com/actions/toolkit/workflows/toolkit-unit-tests/badge.svg"></a>
<a href="https://github.com/actions/toolkit/actions?query=workflow%3Atoolkit-audit"><img alt="Toolkit audit status" src="https://github.com/actions/toolkit/workflows/toolkit-audit/badge.svg"></a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate badge for audit

@ericsciple ericsciple force-pushed the users/ericsciple/m261audit branch from b974d2d to 002ceb0 Compare May 7, 2020 14:37
@ericsciple ericsciple merged commit 83dd3ef into actions:master May 7, 2020
@ericsciple ericsciple deleted the users/ericsciple/m261audit branch May 7, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants