Retry artifact upload/download if a 500 is hit #442
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We should be retrying if a 500 is encountered during either artifact upload or download.
Should fix: actions/download-artifact#33
Looking at telemetry,
v1
triggers these exact same 500s very infrequently (but they do happen) so this isn't something new that all of the sudden started coming up. Thev1
actions treat 500s as retryable. Anything between 400-499 is fail fast while everything else is retried: https://github.com/actions/runner/blob/6c70d53eead402ba5d53676d6ed649a04e219c9b/src/Runner.Plugins/Artifact/FileContainerServer.cs#L483Testing
After a lot of runs, I've managed to actually hit a 500 during download, you can see in the log that it is retired and the download is successful: https://github.com/konradpabjan/artifact-test/runs/622943741?check_suite_focus=true#step:5:223