Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fix for tar exiting with code 1 issue #1108

Merged
merged 15 commits into from
Jun 6, 2022
Merged

Adding fix for tar exiting with code 1 issue #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
197f5a1
Adding fix for tar exiting with code 1 issue
kotewar Jun 1, 2022
1d5b16a
Adding updated package-lock.json for cache
kotewar Jun 1, 2022
9184276
Fixed test case for tar creation
kotewar Jun 3, 2022
1fc4ec3
Pushing updated package-lock.json for artifact
kotewar Jun 3, 2022
a78bb30
Fixed test case for Windows env
kotewar Jun 3, 2022
347d2e2
Changed an import in test case to standard import
kotewar Jun 3, 2022
c1bb3fb
Revert "Changed an import in test case to standard import"
kotewar Jun 3, 2022
845770f
Revert "Revert "Changed an import in test case to standard import""
kotewar Jun 6, 2022
3cf35db
Revert "Changed an import in test case to standard import"
kotewar Jun 6, 2022
49cd1cc
Revert "Fixed test case for Windows env"
kotewar Jun 6, 2022
2d6e5ec
Revert "Pushing updated package-lock.json for artifact"
kotewar Jun 6, 2022
fe93288
Revert "Fixed test case for tar creation"
kotewar Jun 6, 2022
ebfda31
Revert "Adding updated package-lock.json for cache"
kotewar Jun 6, 2022
2fd9a80
Revert "Adding fix for tar exiting with code 1 issue"
kotewar Jun 6, 2022
41c6673
Reverted other package-lock.json
kotewar Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/cache/RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,7 @@
- Update to v2.0.1 of `@actions/http-client` [#1087](https://github.com/actions/toolkit/pull/1087)

### 2.0.5
- Fix to avoid saving empty cache when no files are available for caching. ([issue](https://github.com/actions/cache/issues/624))
- Fix to avoid saving empty cache when no files are available for caching. ([issue](https://github.com/actions/cache/issues/624))

### 2.0.6
- Fix `Tar failed with error: The process '/usr/bin/tar' failed with exit code 1` issue when temp directory where tar is getting created is actually the subdirectory of the path mentioned by the user for caching. ([issue](https://github.com/actions/cache/issues/689))
4 changes: 4 additions & 0 deletions packages/cache/__tests__/tar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ test('zstd create tar', async () => {
'zstd -T0 --long=30',
'-cf',
IS_WINDOWS ? CacheFilename.Zstd.replace(/\\/g, '/') : CacheFilename.Zstd,
'--exclude',
IS_WINDOWS ? CacheFilename.Zstd.replace(/\\/g, '/') : CacheFilename.Zstd,
'-P',
'-C',
IS_WINDOWS ? workspace?.replace(/\\/g, '/') : workspace,
Expand Down Expand Up @@ -180,6 +182,8 @@ test('gzip create tar', async () => {
'-z',
'-cf',
IS_WINDOWS ? CacheFilename.Gzip.replace(/\\/g, '/') : CacheFilename.Gzip,
'--exclude',
IS_WINDOWS ? CacheFilename.Gzip.replace(/\\/g, '/') : CacheFilename.Gzip,
'-P',
'-C',
IS_WINDOWS ? workspace?.replace(/\\/g, '/') : workspace,
Expand Down
4 changes: 2 additions & 2 deletions packages/cache/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/cache/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@actions/cache",
"version": "2.0.5",
"version": "2.0.6",
"preview": true,
"description": "Actions cache lib",
"keywords": [
Expand Down
2 changes: 2 additions & 0 deletions packages/cache/src/internal/tar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ export async function createTar(
...getCompressionProgram(),
'-cf',
cacheFileName.replace(new RegExp(`\\${path.sep}`, 'g'), '/'),
'--exclude',
cacheFileName.replace(new RegExp(`\\${path.sep}`, 'g'), '/'),
'-P',
'-C',
workingDirectory.replace(new RegExp(`\\${path.sep}`, 'g'), '/'),
Expand Down