-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1693 from actions/bdehamer/oidc-provenance
(@actions/attest) build provenance statement from OIDC claims
- Loading branch information
Showing
13 changed files
with
1,018 additions
and
199 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
# @actions/attest Releases | ||
|
||
### 1.1.0 | ||
|
||
- Updates the `attestProvenance` function to retrieve a token from the GitHub OIDC provider and use the token claims to populate the provenance statement. | ||
|
||
### 1.0.0 | ||
|
||
- Initial release |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/attest/__tests__/__snapshots__/provenance.test.ts.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,147 @@ | ||
import * as jose from 'jose' | ||
import nock from 'nock' | ||
import {getIDTokenClaims} from '../src/oidc' | ||
|
||
describe('getIDTokenClaims', () => { | ||
const originalEnv = process.env | ||
const issuer = 'https://example.com' | ||
const audience = 'nobody' | ||
const requestToken = 'token' | ||
const openidConfigPath = '/.well-known/openid-configuration' | ||
const jwksPath = '/.well-known/jwks.json' | ||
const tokenPath = '/token' | ||
const openIDConfig = {jwks_uri: `${issuer}${jwksPath}`} | ||
|
||
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */ | ||
let key: any | ||
|
||
beforeEach(async () => { | ||
process.env = { | ||
...originalEnv, | ||
ACTIONS_ID_TOKEN_REQUEST_URL: `${issuer}${tokenPath}?`, | ||
ACTIONS_ID_TOKEN_REQUEST_TOKEN: requestToken | ||
} | ||
|
||
// Generate JWT signing key | ||
key = await jose.generateKeyPair('PS256') | ||
|
||
// Create JWK and JWKS | ||
const jwk = await jose.exportJWK(key.publicKey) | ||
const jwks = {keys: [jwk]} | ||
|
||
nock(issuer).get(openidConfigPath).reply(200, openIDConfig) | ||
nock(issuer).get(jwksPath).reply(200, jwks) | ||
}) | ||
|
||
afterEach(() => { | ||
process.env = originalEnv | ||
}) | ||
|
||
describe('when ID token is valid', () => { | ||
const claims = { | ||
iss: issuer, | ||
aud: audience, | ||
ref: 'ref', | ||
sha: 'sha', | ||
repository: 'repo', | ||
event_name: 'push', | ||
workflow_ref: 'main', | ||
repository_id: '1', | ||
repository_owner_id: '1', | ||
runner_environment: 'github-hosted', | ||
run_id: '1', | ||
run_attempt: '1' | ||
} | ||
|
||
beforeEach(async () => { | ||
const jwt = await new jose.SignJWT(claims) | ||
.setProtectedHeader({alg: 'PS256'}) | ||
.sign(key.privateKey) | ||
|
||
nock(issuer).get(tokenPath).query({audience}).reply(200, {value: jwt}) | ||
}) | ||
|
||
it('returns the ID token claims', async () => { | ||
const result = await getIDTokenClaims(issuer) | ||
expect(result).toEqual(claims) | ||
}) | ||
}) | ||
|
||
describe('when ID token is missing required claims', () => { | ||
const claims = { | ||
iss: issuer, | ||
aud: audience | ||
} | ||
|
||
beforeEach(async () => { | ||
const jwt = await new jose.SignJWT(claims) | ||
.setProtectedHeader({alg: 'PS256'}) | ||
.sign(key.privateKey) | ||
|
||
nock(issuer).get(tokenPath).query({audience}).reply(200, {value: jwt}) | ||
}) | ||
|
||
it('throws an error', async () => { | ||
await expect(getIDTokenClaims(issuer)).rejects.toThrow(/missing claims/i) | ||
}) | ||
}) | ||
|
||
describe('when ID has the wrong issuer', () => { | ||
const claims = {foo: 'bar', iss: 'foo', aud: 'nobody'} | ||
|
||
beforeEach(async () => { | ||
const jwt = await new jose.SignJWT(claims) | ||
.setProtectedHeader({alg: 'PS256'}) | ||
.sign(key.privateKey) | ||
|
||
nock(issuer).get(tokenPath).query({audience}).reply(200, {value: jwt}) | ||
}) | ||
|
||
it('throws an error', async () => { | ||
await expect(getIDTokenClaims(issuer)).rejects.toThrow(/issuer invalid/) | ||
}) | ||
}) | ||
|
||
describe('when ID has the wrong audience', () => { | ||
const claims = {foo: 'bar', iss: issuer, aud: 'bar'} | ||
|
||
beforeEach(async () => { | ||
const jwt = await new jose.SignJWT(claims) | ||
.setProtectedHeader({alg: 'PS256'}) | ||
.sign(key.privateKey) | ||
|
||
nock(issuer).get(tokenPath).query({audience}).reply(200, {value: jwt}) | ||
}) | ||
|
||
it('throw an error', async () => { | ||
await expect(getIDTokenClaims(issuer)).rejects.toThrow(/audience invalid/) | ||
}) | ||
}) | ||
|
||
describe('when openid config cannot be retrieved', () => { | ||
const claims = {foo: 'bar', iss: issuer, aud: 'nobody'} | ||
|
||
beforeEach(async () => { | ||
const jwt = await new jose.SignJWT(claims) | ||
.setProtectedHeader({alg: 'PS256'}) | ||
.sign(key.privateKey) | ||
|
||
nock(issuer).get(tokenPath).query({audience}).reply(200, {value: jwt}) | ||
|
||
// Disable the openid config endpoint | ||
nock.removeInterceptor({ | ||
proto: 'https', | ||
hostname: 'example.com', | ||
port: '443', | ||
method: 'GET', | ||
path: openidConfigPath | ||
}) | ||
}) | ||
|
||
it('throws an error', async () => { | ||
await expect(getIDTokenClaims(issuer)).rejects.toThrow( | ||
/failed to get id/i | ||
) | ||
}) | ||
}) | ||
}) |
Oops, something went wrong.