Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): enhance the logs #358

Merged
merged 29 commits into from
Mar 8, 2021
Merged

chore(logs): enhance the logs #358

merged 29 commits into from
Mar 8, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Mar 5, 2021

Changes:

Partial of #347
Closes #361

C0ZEN and others added 20 commits November 22, 2020 10:55
feat(stale-and-close): add new options to change the days before clos…
Remove the stale label when labeled with an exempt one  (actions#268)
feat(statistics): display some stats in the logs (actions#337)
* docs(only-labels): remove duplicated option and improve descriptions

a bad rebase happend

* docs(readme): use a multi-line array and remove the optional column

the option column was not helpful since each value is optional
the multi-line array will allow to have a better UI in small devices and basically in GitHub too due to the max-width

* style(readme): break line for the statistics

* docs(readme): add a better description for the ascending option

* docs(action): add missing punctuation
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.3.0 to 18.3.2.
- [Release notes](https://github.com/octokit/rest.js/releases)
- [Commits](octokit/rest.js@v18.3.0...v18.3.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tl;dr: blue for values, megenta for options, white for messages, yellow light for warnings, yellow for milestones and green for success
still a WIP but I wish to confirm this before continuing
@hross is it ok for you?
@C0ZEN C0ZEN marked this pull request as ready for review March 5, 2021 23:05
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Mar 5, 2021

@hross hello.
This PR is very opinionated regarding the logs due to including colored ones.
I wish to know if it's ok with you or if you want to change something or if you want to drop the color.
I wait your feedback before continuing.

Example

@hross
Copy link
Contributor

hross commented Mar 6, 2021

I love the colors! let me know if you want me to merge now or wait

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Mar 6, 2021

@hross 😎 yes you can merge it so I will be able to see if it is working through the octokit logs. I will provide a second PR soon

@hross hross merged commit b717aa9 into actions:main Mar 8, 2021
@hross
Copy link
Contributor

hross commented Mar 8, 2021

will let this sit in master until the end of the week and release it.

@C0ZEN C0ZEN deleted the feature/logs branch March 8, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the operations left to make it a class
2 participants