fix: don't override AGENT_TOOLSDIRECTORY if it's not needed
#564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AGENT_TOOLSDIRECTORY` is always overriden on macOS. This seems to be needed because CPython < 3.11 x64 builds are not relocatable. It means this is not needed for PyPy and also not needed when targetting macOS arm64 runners.
|
@dsame could you have a look at this? It's related to #394 I believe this section of the docs explains why we do this. @mayeut I understand why we don't need it for PyPy, but could you explain why it's not needed for macOS arm64 runners? |
|
This would need a full rework with the new multi versions support.
@brcrista, if using universal2 installers as proposed in actions/python-versions#214, then the python installation is always installed in a fixed framework location and the tool cache only manages symlinks. We can create those symlinks wherever we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Don't override
AGENT_TOOLSDIRECTORYif it's not needed:AGENT_TOOLSDIRECTORYis always overriden on macOS.This seems to be needed because CPython < 3.11 x64 builds are not relocatable
It means this is not needed for PyPy and also not needed when targetting macOS arm64 runners.
Related issue:
Towards #547
Check list: