Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding a token on GHES to prevent rate limiting #316

Closed
wants to merge 2 commits into from

Conversation

HenrikPoulsen
Copy link

Description:
Adding a new input to specify a token when running on GHES.
When running on GHES today token gets thrown away even when explicitly set to be a github.com token.
So there is no good way to avoid the rate limiting that would occur.

No idea if this change is idiomatic or not since I don't usually work with typescript.
So let me know if there's any changes you would want me to make.

Related issue:
#229

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed different approaches to this problem. This approach should work, but requiring users to create a PAT in github.com to then use in GHES would create more problems than it would solve.

I think the best approach to unblock you is to fork the action on your GHES instance and apply these changes.

@HenrikPoulsen
Copy link
Author

What about fixing this for everyone that isn't me then?
Will something be done to fix this rate limiting issue? This PR at least proposes a generic workaround. Is it a hassle to set up? Sure
Does it solve a problem for people who are straight up blocked? Yes
Just making sure this isn't the end of the road for fixing this issue permanently

@lasse-aagren
Copy link

lasse-aagren commented Jan 24, 2022

The solution implemented in this PR will continue to work exactly as today, for users not setting up til github.com PAT in their GHE project.

It will work until they hit a rate limit.

This PR provides a solution to that, for those interested. Isn't that to prefer, compared to not have a solution?

@brcrista
Copy link
Contributor

It doesn't seem like a common issue so far, but we have thought about it.

Having to add a GHES-specific input to an action suggests to me that there's a smoother flow we should look for on the backend. The solution we would like to implement is to make this flow part of GitHub Connect. That would solve the problem in a general way for all first-party actions and be consistent with other flows that fit this pattern. No ETA on this, though.

@Vercasek1985
Copy link

Hello @brcrista
I am working in the automation team. We do the automation in ansible. Github is used heavily in our company (Kyndryl) and we really need this fix ASAP. Could you please help me, what can we do to prioritize this issue to be fixed in very near future?

@brcrista
Copy link
Contributor

brcrista commented Jun 2, 2022

@Vercasek1985 I recommend forking the action to unblock yourself. As I said above, passing a PAT is a quick fix but not something that we want to support long-term.

@HenrikPoulsen I'm going to close this PR since we're not planning on merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants