Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v8-canary release #619

Closed
wants to merge 19 commits into from
Closed

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Nov 9, 2022

Description:
Download v8 canary releases from https://nodejs.org/download/v8-canary in case if version has-v8-canary as a suffix or a part.

test build https://github.com/akv-demo/setup-node-test/actions/runs/3425995155

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame force-pushed the v-sdolin/v8-canary branch 7 times, most recently from c94a504 to de40daa Compare November 9, 2022 19:43
@dsame dsame mentioned this pull request Nov 11, 2022
2 tasks
src/installer.ts Outdated Show resolved Hide resolved
@dsame dsame marked this pull request as ready for review November 24, 2022 11:26
@dsame dsame requested a review from a team November 24, 2022 11:26
docs/advanced-usage.md Outdated Show resolved Hide resolved
.github/workflows/versions.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/versions.yml Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
Comment on lines +100 to +101
// TODO: dmitry's variant was potential.replace('-nightly', '-nightly.') that made
// all unit tests to fail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please share an example of their fallings to investigate it deeper because I'd like to not split function for raw and range.

Copy link
Contributor Author

@dsame dsame Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const potential='v20.0.0-nightly20221103f7e2421e91'
const raw='v20'
const validVersion = semver.valid(raw) ? raw : semver.coerce(raw)?.version;

const range = semver.validRange(`^${version}`);
semver.satisfies(potential.replace('-nightly', '-nightly.'),range) // false
semver.satisfies(potential.replace('-nightly', '-nightly.'),range,{includePrerelease: true}) // false

const range0 = `${semver.validRange(`^${version}-0`)}-0`;
semver.satisfies(potential.replace('-nightly', '-nightly.'),range0) // false
semver.satisfies(potential.replace('-nightly', '-nightly.'),range0,{includePrerelease: true}) // false

semver.satisfies(potential.replace('-nightly', '+nightly.'),range) // true

__tests__/installer.test.ts Outdated Show resolved Hide resolved
fuxingloh referenced this pull request in BirthdayResearch/jellyfishsdk Jan 6, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dmitry-shibanov
Copy link
Contributor

I'm going to close the pull request in favour of this: #655

andipaetzold referenced this pull request in andipaetzold/react-firehooks Feb 10, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/andipaetzold/react-firehooks).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
beeme1mr referenced this pull request in open-feature/flagd-schemas Mar 17, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/open-feature/schemas).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTAuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh referenced this pull request in fuxingloh/contented Jun 10, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh referenced this pull request in levaintech/sticky Jun 19, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/levaintech/sticky).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants