Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the token input through on GHES #595

Merged

Conversation

dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Oct 17, 2022

Description:
In scope of this pull request we make available to pass GitHub token on GHES.

Related issue:
https://github.com/actions/runner-images-internal/issues/4479

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov dmitry-shibanov requested a review from a team October 17, 2022 10:48
Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to the change to action.yml here: https://github.com/actions/setup-python/pull/443/files

On GHES, this will start using GITHUB_TOKEN (the default value for the token input) to make calls to github.com. But, the GHES token isn't valid on github.com.

@dmitry-shibanov dmitry-shibanov merged commit 00e1b66 into actions:main Nov 2, 2022
fuxingloh referenced this pull request in BirthdayResearch/jellyfishsdk Jan 6, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
andipaetzold referenced this pull request in andipaetzold/react-firehooks Feb 10, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/andipaetzold/react-firehooks).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
beeme1mr referenced this pull request in open-feature/flagd-schemas Mar 17, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/open-feature/schemas).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTAuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh referenced this pull request in fuxingloh/contented Jun 10, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Anglemmj7
Copy link

#595 (comment)

fuxingloh referenced this pull request in levaintech/sticky Jun 19, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-node](https://togithub.com/actions/setup-node) | action
| minor | `v3.5.1` -> `v3.6.0` |

---

### Release Notes

<details>
<summary>actions/setup-node</summary>

###
[`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0):
Add Support for Nightly, Canary and RC builds for Node.js

[Compare
Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0)

In scope of this release we added support to download nightly, rc
([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611))
and canary
([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619))
Node.js distributions.

##### For nightly versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-nightly'
      - run: npm ci
      - run: npm test
```

##### For canary versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16-v8-canary’
      - run: npm ci
      - run: npm test
```

##### For rc versions:

```yaml
jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test
```

Note: For more examples please refer to
[documentation](https://togithub.com/actions/setup-node#advanced-usage).

Besides, we added the following changes as:

- Updated minimatch:
[https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608)
- Fixed extra newline character in version output when reading from a
file:
[https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625)
- Passed the token input through on GHES:
[https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595)
- Fixed issue with scoped registries are duplicated in npmrc:
[https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/levaintech/sticky).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants