-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the token input through on GHES #595
Merged
dmitry-shibanov
merged 3 commits into
actions:main
from
dmitry-shibanov:v-dmshib/pass-token-on-ghes
Nov 2, 2022
Merged
Pass the token input through on GHES #595
dmitry-shibanov
merged 3 commits into
actions:main
from
dmitry-shibanov:v-dmshib/pass-token-on-ghes
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-zivic-93
approved these changes
Oct 17, 2022
IvanZosimov
approved these changes
Oct 17, 2022
vsafonkin
approved these changes
Oct 17, 2022
brcrista
suggested changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to the change to action.yml
here: https://github.com/actions/setup-python/pull/443/files
On GHES, this will start using GITHUB_TOKEN
(the default value for the token
input) to make calls to github.com. But, the GHES token isn't valid on github.com.
brcrista
approved these changes
Oct 26, 2022
marko-zivic-93
approved these changes
Oct 27, 2022
fuxingloh
referenced
this pull request
in BirthdayResearch/jellyfishsdk
Jan 6, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611)) and canary ([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619)) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608) - Fixed extra newline character in version output when reading from a file: [https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625) - Passed the token input through on GHES: [https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595) - Fixed issue with scoped registries are duplicated in npmrc: [https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
andipaetzold
referenced
this pull request
in andipaetzold/react-firehooks
Feb 10, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611)) and canary ([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619)) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608) - Fixed extra newline character in version output when reading from a file: [https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625) - Passed the token input through on GHES: [https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595) - Fixed issue with scoped registries are duplicated in npmrc: [https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/andipaetzold/react-firehooks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
beeme1mr
referenced
this pull request
in open-feature/flagd-schemas
Mar 17, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611)) and canary ([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619)) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608) - Fixed extra newline character in version output when reading from a file: [https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625) - Passed the token input through on GHES: [https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595) - Fixed issue with scoped registries are duplicated in npmrc: [https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/schemas). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTAuMiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh
referenced
this pull request
in fuxingloh/contented
Jun 10, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611)) and canary ([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619)) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608) - Fixed extra newline character in version output when reading from a file: [https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625) - Passed the token input through on GHES: [https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595) - Fixed issue with scoped registries are duplicated in npmrc: [https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh
referenced
this pull request
in levaintech/sticky
Jun 19, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([https://github.com/actions/setup-node/pull/611](https://togithub.com/actions/setup-node/pull/611)) and canary ([https://github.com/actions/setup-node/pull/619](https://togithub.com/actions/setup-node/pull/619)) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [https://github.com/actions/setup-node/pull/608](https://togithub.com/actions/setup-node/pull/608) - Fixed extra newline character in version output when reading from a file: [https://github.com/actions/setup-node/pull/625](https://togithub.com/actions/setup-node/pull/625) - Passed the token input through on GHES: [https://github.com/actions/setup-node/pull/595](https://togithub.com/actions/setup-node/pull/595) - Fixed issue with scoped registries are duplicated in npmrc: [https://github.com/actions/setup-node/pull/637](https://togithub.com/actions/setup-node/pull/637) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/levaintech/sticky). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In scope of this pull request we make available to pass GitHub token on GHES.
Related issue:
https://github.com/actions/runner-images-internal/issues/4479
Check list: