Housekeeping: Update zeit/ncc to vercel/ncc #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hello @KengoTODA. Thank you for your pull request. It looks good, but because it produces a lot of changes for dist directory I'd like to test it more from our side. When we test it from our side, we'll merge your pull request. |
KengoTODA
force-pushed
the
update-ncc-3rd
branch
from
2e2ea68 to
fb7f8a3
Compare
|
The build failed due to an unstable npm repository. Simply run the workflow run then it will pass. I've confirmed in my repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #190 because vercel/ncc#748 has been fixed.
Description:
zeit/ncc is no longer maintained, so it's better to replace it with vercel/ncc.
I've confirmed that this change does not affect file size so much:
dist/cleanup/index.js: 2694241 -> 2690020 (-4221 bytes)dist/setup/index.js: 4060921 -> 4060960 (+39 bytes)Related issue:
None
Check list: