Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-dotnet in version 1.7.0 no longer works correctly for channel versions, such as 3.1 or 3.1.x #128

Closed
JustArchi opened this issue Sep 21, 2020 · 6 comments · Fixed by #131

Comments

@JustArchi
Copy link

JustArchi commented Sep 21, 2020

Description

setup-dotnet in version 1.7.0 no longer works correctly for channel versions, such as 3.1 or 3.1.x (which is interpreted the same).

Details

This is a regression. Version 1.6.0 is working fine. Example log output can be found here

Run actions/setup-dotnet@v1
  with:
    dotnet-version: 3.1
  env:
    CONFIGURATION: Release
    DOTNET_CLI_TELEMETRY_OPTOUT: 1
    DOTNET_NOLOGO: 1
    DOTNET_SDK_VERSION: 3.1
    NET_CORE_VERSION: netcoreapp3.1
    NET_FRAMEWORK_VERSION: net48
    NODE_JS_VERSION: 12
    STEAM_TOKEN_DUMPER_NAME: ArchiSteamFarm.OfficialPlugins.SteamTokenDumper
    STEAM_TOKEN_DUMPER_TOKEN: ***
/Users/runner/work/_actions/actions/setup-dotnet/v1/externals/install-dotnet.sh --version 3.1
dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1/dotnet-sdk-3.1-osx-x64.tar.gz
curl: (22) The requested URL returned error: 404 Not Found
dotnet-install: Cannot download: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1/dotnet-sdk-3.1-osx-x64.tar.gz
dotnet-install: Downloading legacy link: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1/dotnet-dev-osx-x64.3.1.tar.gz
curl: (22) The requested URL returned error: 404 Not Found
dotnet-install: Cannot download: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1/dotnet-dev-osx-x64.3.1.tar.gz
dotnet_install: Error: Could not find/download: `.NET Core SDK` with version = 3.1
dotnet_install: Error: Refer to: https://aka.ms/dotnet-os-lifecycle for information on .NET Core support
##[error]The process '/Users/runner/work/_actions/actions/setup-dotnet/v1/externals/install-dotnet.sh' failed with exit code 1

Example yaml file can be found here. Replacing @v1 (which points to 1.7.0 as of today) with @v1.6.0 fixes the issue, as can be verified here.

Let me know if you need more info. Judging from how easily it regressed in my setup, I believe there shouldn't be too much trouble localizing the culprit. Thank you in advance for your interest.

@Shane32
Copy link

Shane32 commented Sep 21, 2020

Breaks all my deployment scripts. Considering that the "basic" sample in the readme file now is broken, there are probably hundreds or thousands of people with broken scripts. This should probably be fixed or reverted to the prior version immediately.

from readme:

steps:
- uses: actions/checkout@main
- uses: actions/setup-dotnet@v1
  with:
    dotnet-version: '3.1.x' # SDK Version to use; x will use the latest version of the 3.1 channel
- run: dotnet build <my project>

@veilofsecurity
Copy link

Confirming all of our deployments are also broken now, commits this morning worked but latest ones failing.

@iris-hpaterson
Copy link

iris-hpaterson commented Sep 22, 2020

We've experienced this issue breaking the ${{ env.DOTNET_ROOT }} environment environment variable in Github Actions. The variable is either set empty or not set at all.

Actions provided by Microsoft Azure to deploy webapps depend on DOTNET_ROOT being set.

This also breaks version requests in the style dotnet-version: 3.1.x, which have to be hard pegged to a version.

We've hotfixed by rolling back to v1.6.0.

@Hoopie
Copy link

Hoopie commented Sep 22, 2020

setup-dotnet no longer works on ubuntu-latest

Looks like the ubuntu-latest image (18.04.5 LTS) now contains the dotnet cli installed by default not requiring this action.
The setup-dotnet action however adds the matchers to pull out annotations.

We got our builds running but removing this action BUT are no longer getting annotations generated from the cli output.

Would love a patch asap

ref:

RomainMuller added a commit to aws/jsii that referenced this issue Sep 22, 2020
The current version (1.7.0) fails to install our required versions correctly (see actions/setup-dotnet#128). Pinning to the previous release until that gets fixed.
@RomainMuller
Copy link

Looks like the ubuntu-latest image (18.04.5 LTS) now contains the dotnet cli installed by default not requiring this action.

Well, not requiring this action unless you need a different version of the dotnet cli...

@ZEisinger
Copy link
Contributor

I've reverted the tag update for v1 back to 1.6.0 and will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants