Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve dates when deserializing job message from Run Service #3269

Merged
merged 2 commits into from
May 2, 2024
Merged

Preserve dates when deserializing job message from Run Service #3269

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da6f82d
Preserve dates when deserializing job message from Run Service
ericsciple May 1, 2024
4dd32f1
Preserve dates when deserializing job message from "Actions Run Service"
ericsciple May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Sdk/RSWebApi/RunServiceHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,23 @@
using GitHub.Services.Common;
using GitHub.Services.OAuth;
using GitHub.Services.WebApi;
using Newtonsoft.Json;
ericsciple marked this conversation as resolved.
Show resolved Hide resolved
using Sdk.RSWebApi.Contracts;
using Sdk.WebApi.WebApi;

namespace GitHub.Actions.RunService.WebApi
{
public class RunServiceHttpClient : RawHttpClientBase
{
private static readonly JsonSerializerSettings s_serializerSettings;

static RunServiceHttpClient()
{
s_serializerSettings = new VssJsonMediaTypeFormatter().SerializerSettings;
s_serializerSettings.DateParseHandling = DateParseHandling.None;
s_serializerSettings.FloatParseHandling = FloatParseHandling.Double;
}

public RunServiceHttpClient(
Uri baseUrl,
VssOAuthCredential credentials)
Expand Down Expand Up @@ -174,5 +184,11 @@ public async Task<RenewJobResponse> RenewJobAsync(
throw new Exception($"Failed to renew job: {result.Error}");
}
}

protected override async Task<T> ReadJsonContentAsync<T>(HttpResponseMessage response, CancellationToken cancellationToken = default(CancellationToken))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a virtual method on RawHttpClientBase

runner/src/Sdk/WebApi/WebApi/RawHttpClientBase.cs

Line 235 in 04b07b6

protected virtual async Task<T> ReadJsonContentAsync<T>(HttpResponseMessage response, CancellationToken cancellationToken = default(CancellationToken))

{
var json = await response.Content.ReadAsStringAsync(cancellationToken).ConfigureAwait(false);
return JsonConvert.DeserializeObject<T>(json, s_serializerSettings);
}
}
}
Loading