Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -f flag in wait when manually trap signal #3182

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

nikola-jokic
Copy link
Contributor

Fixes #3181

@nikola-jokic nikola-jokic requested a review from a team as a code owner March 1, 2024 08:27
@pmartindev
Copy link

pmartindev commented Mar 1, 2024

Hey @nikola-jokic, do you see any risk in removing the -f flag? I tried finding more information on why it was used, but didn't have much luck 😦

@nikola-jokic
Copy link
Contributor Author

Hey @pmartindev,

I think I just made a mistake with the -f flag ☺️ I don't remember why I used it, and I double-checked the manual and found no instances of -f flag. I used wait on exit without the flag here, so I think this was just a mistake on my end ☺️

@nikola-jokic nikola-jokic merged commit 86d6211 into main Mar 4, 2024
10 checks passed
@nikola-jokic nikola-jokic deleted the nikola-jokic/remove-wait-flag branch March 4, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to connect ARC runner with SLES 15 image
3 participants