Fix color code detection in OutputManager #2430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbb
added a commit
to actions-rust-lang/setup-rust-toolchain
that referenced
this pull request
Mar 17, 2023
The action runner currently fails to strip color codes from the output. This means that many matchers currectly do not work. actions/runner#2341 actions/runner#2430 The new matcher is copied from kaj/rsass which is MIT licensed. https://github.com/kaj/rsass/blob/3e5d6c0600324fe27b0a0257d3befd4bb345fedb/.github/workflows/rust-problem-matcher.json
ian-h-chamberlain
force-pushed
the
fix/proper-escape-color-code
branch
from
071a612 to
3a319d3
Compare
This was a simple case of a mistaken translation from shell escape cades (which support "\nnn") to C# (which only supports "\xNN" and "\uNNNN"). The test was passing because it also used invalid escape codes.
ian-h-chamberlain
force-pushed
the
fix/proper-escape-color-code
branch
from
3a319d3 to
c21dc60
Compare
|
This was marked as stale, but as far as I know is still needed and the fix is still valid. Not sure if there's any way to unstale or get a review / CI besides just commenting here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2341
This was a simple case of a mistaken translation from shell escape codes (which support octal
\NNN) to C# (which only supports hex\xNNand\uNNNNin string literals, but does support octal\NNNinRegex). The test was passing because it also used incorrect escape codes, which matched the incorrect prefix.Edit: manual testing against the original repro repo: https://github.com/ian-h-chamberlain/actions-color-repro/actions/runs/4157866967