Job container + container services #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 5, 2019 17:25
TingluoHuang
reviewed
Jun 8, 2019
TingluoHuang
reviewed
Jun 8, 2019
|
did you talk with Chris about removing the logic to handle file permission different? |
| _pathMappings[hostContext.GetDirectory(WellKnownDirectory.Tools)] = "/__t"; // Tool cache folder may come from ENV, so we need a unique folder to avoid collision | ||
| _pathMappings[hostContext.GetDirectory(WellKnownDirectory.Work)] = "/__w"; | ||
| _pathMappings[hostContext.GetDirectory(WellKnownDirectory.Root)] = "/__a"; |
There was a problem hiding this comment.
do we still need the __a? we had it because we have variables like Agent.HomeDirectory, so i have to make it shows reasonable when you get inside container, i don't think we need it anymore
added 6 commits
June 12, 2019 16:22
Conflicts: src/Runner.Worker/ExecutionContext.cs
dakale
commented
Jun 17, 2019
| @@ -246,7 +246,9 @@ private async Task StartContainerAsync(IExecutionContext executionContext, Conta | |||
| container.AddPortMappings(await _dockerManger.DockerPort(executionContext, container.ContainerId)); | |||
| foreach (var port in container.PortMappings) | |||
| { | |||
| executionContext.SetRunnerContext($"service.{container.ContainerNetworkAlias}.ports.{port.ContainerPort}", port.HostPort); | |||
| var contextVarName = $"service_{container.ContainerNetworkAlias}_ports_{port.ContainerPort}"; | |||
There was a problem hiding this comment.
@TingluoHuang Is this still the right pattern? Ive tested it and it still works, the ports show up in the host process env as e.g. AGENT_SERVICE_REDIS_PORTS_6379=32771 I am just wondering if this is the best way to expose information to the runner at runtime.
Should we also change the prefix to RUNNER instead of AGENT?
added 2 commits
June 18, 2019 13:12
Avoid needing to fumble paths together by splitting org/repo name later
added 4 commits
June 18, 2019 15:32
in container workdir is relative path from workdir which is concat from host work dir and source dir
jsoref
pushed a commit
to jsoref/actions-runner
that referenced
this pull request
Oct 7, 2022
* Fix parallel 1, no runner available actions#23 * Make runner early available * Check if parallel 1 works
mattrwi
pushed a commit
to mattrwi/runner
that referenced
this pull request
Oct 9, 2024
release workflow update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes node intermediate handler script
dockeris exec'd with the environment, which maps the environment into the command run bydocker execScript is run directly via
docker execrather than execing a node script that then runs the scriptNeed to iterate on mapping in path