Set timeout when sending live console log to service #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
commented
May 19, 2022
| @@ -1,5 +1,4 @@ | |||
| using GitHub.DistributedTask.WebApi; | |||
There was a problem hiding this comment.
hide whitespace when reviewing.
TingluoHuang
commented
May 19, 2022
| @@ -274,7 +274,7 @@ public async Task AppendTimelineRecordFeedAsync(Guid scopeIdentifier, string hub | |||
| } | |||
| } | |||
|
|
|||
| if (!pushedLinesViaWebsocket) | |||
| if (!pushedLinesViaWebsocket && !cancellationToken.IsCancellationRequested) | |||
There was a problem hiding this comment.
failback to HttpClient only if we haven't been cancelled.
TingluoHuang
commented
May 19, 2022
| @@ -48,7 +48,7 @@ | |||
|
|
|||
| <Target Name="Test" DependsOnTargets="GenerateConstant"> | |||
| <Exec Command="dotnet build Test/Test.csproj -c $(BUILDCONFIG) /p:PackageRuntime=$(PackageRuntime)" ConsoleToMSBuild="true" /> | |||
| <Exec Command="dotnet test Test/Test.csproj --no-build --logger:trx" ConsoleToMSBuild="true" /> | |||
| <Exec Command="dotnet test Test/Test.csproj -c $(BUILDCONFIG) --no-build --logger:trx" ConsoleToMSBuild="true" /> | |||
There was a problem hiding this comment.
i noticed ./dev.sh test Release is not working... this should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
websocketClient.SendAsync()doesn't have a default timeout, which means if the WebSocket is in a bad state, the client (runner) won't abort the request until the service kills the connection after 10 minutes (Max connection time control by AFD).I am adding a CancellationToken to auto-fire after 60 seconds to avoid the runner sitting there and waiting for the 10 minutes timeout.