Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add group and endgroup commands #106

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Sep 16, 2019

Tested on the following yaml:

on: push
name: Test
jobs:
  abbbbbb:
    name: abbbbbb
    runs-on:
      pool: default
    steps:
    - name: aaaaaaa
      id: step1
      run: |
        echo ::group::
        echo hello world
        echo test
        echo ::endgroup::
        echo test
        echo test2

got the following output

2019-09-16T20:53:12.1180421Z ##[group]Run echo ::group::
2019-09-16T20:53:12.1230404Z �[36;1mecho ::group::�[0m
2019-09-16T20:53:12.1230680Z �[36;1mecho hello world�[0m
2019-09-16T20:53:12.1230885Z �[36;1mecho test�[0m
2019-09-16T20:53:12.1231089Z �[36;1mecho ::endgroup::�[0m
2019-09-16T20:53:12.1231293Z �[36;1mecho test�[0m
2019-09-16T20:53:12.1231492Z �[36;1mecho test2�[0m
2019-09-16T20:53:12.1237271Z shell: C:\windows\system32\cmd.exe /D /E:ON /V:OFF /S /C "CALL "{0}""
2019-09-16T20:53:12.1238121Z ##[endgroup]
2019-09-16T20:53:12.1600320Z ##[group]
2019-09-16T20:53:12.1601035Z hello world
2019-09-16T20:53:12.1601274Z test
2019-09-16T20:53:12.1601628Z ##[endgroup]
2019-09-16T20:53:12.1601862Z test
2019-09-16T20:53:12.1602130Z test2

@bryanmacfarlane
Copy link
Member

Shouldn't group have a group title? e.g. echo ::group::foo

@bryanmacfarlane
Copy link
Member

@bryanmacfarlane
Copy link
Member

Also, the ::group shouldn't make it's way to the log / server, right? The step should emit the consistent ::group, the runner intercepts and that turns into ## log decorations, right? In other words, the ::group is the use facing command and the ## is the internal protocol for the log to decorate.

I ask because in the output example above, I see both.

@thboop
Copy link
Collaborator Author

thboop commented Sep 16, 2019

Also, the ::group shouldn't make it's way to the log / server, right? The step should emit the consistent ::group, the runner intercepts and that turns into ## log decorations, right? In other words, the ::group is the use facing command and the ## is the internal protocol for the log to decorate.

I ask because in the output example above, I see both.

It will not, it only did in this example because i'm using a step to echo that value

@thboop
Copy link
Collaborator Author

thboop commented Sep 16, 2019

Shouldn't group have a group title? e.g. echo ::group::foo

this has been updated!

@TingluoHuang TingluoHuang merged commit dc490dc into master Sep 16, 2019
@TingluoHuang TingluoHuang deleted the users/thboop/addgroupcommands branch September 16, 2019 23:45
@bryanmacfarlane
Copy link
Member

Here's the toolkit issue we can reference in the release: actions/toolkit#112

volker-raschek pushed a commit to dedalus-cis4u/github-runner-role that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants